Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ModuleKind to graph #107

Merged
merged 2 commits into from
Jan 20, 2022
Merged

feat: add ModuleKind to graph #107

merged 2 commits into from
Jan 20, 2022

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Jan 19, 2022

Closes #97

@lucacasonato
Copy link
Member

Not super fond of the name ModuleKind. We have an awful lot of "module kind/type" enums all over the place representing slightly different things. It'd be great if we found a more unique name for this.

bartlomieju
bartlomieju reviewed Jan 19, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherret please take a look

lib/types.d.ts Outdated Show resolved Hide resolved
mod.ts Show resolved Hide resolved
mod.ts Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
dsherret
dsherret reviewed Jan 19, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I feel like we could change the ModuleKind enum to get rid of the value in Asserted.

src/graph.rs Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Outdated Show resolved Hide resolved
src/graph.rs Show resolved Hide resolved
src/graph.rs Show resolved Hide resolved
src/graph.rs Show resolved Hide resolved
dsherret
dsherret approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 7c8b632 into denoland:main Jan 20, 2022
@kitsonk kitsonk deleted the kitsonk/issue97 branch January 20, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ModuleKind to graph and be returned by Resolver.resolve
4 participants
@kitsonk @lucacasonato @dsherret @bartlomieju