Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): disable test-child-process-execfile.js #2593

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Sep 1, 2022

The compat test case test-child-process-execfile.js depends on unstable --compat flag feature of CLI. The --compat feature is going to be removed soon in denoland/deno#15678 . There seems no alternative way to pass these test cases without --compat. This PR temporarily removes these test cases.

@kt3k kt3k requested a review from bartlomieju as a code owner September 1, 2022 04:18
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 6d7da70 into denoland:main Sep 1, 2022
@kt3k kt3k deleted the chore-disable-test-child-process-execfile branch September 1, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants