Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): move _buffer.mjs to node/internal #2643

Merged
merged 1 commit into from
Sep 12, 2022
Merged

refactor(node): move _buffer.mjs to node/internal #2643

merged 1 commit into from
Sep 12, 2022

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 11, 2022

Takes care of buffer for #1707, bringing things closer to the Node codebase.

@iuioiua iuioiua marked this pull request as ready for review September 11, 2022 23:36
@iuioiua iuioiua changed the title refactor(node): move _buffer.mjs to internal [WIP] refactor(node): move _buffer.mjs to internal Sep 11, 2022
@iuioiua iuioiua changed the title refactor(node): move _buffer.mjs to internal refactor(node): move _buffer.mjs to node/internal Sep 11, 2022
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@kt3k kt3k merged commit ac59482 into denoland:main Sep 12, 2022
@iuioiua iuioiua deleted the refactor(node)--move-_buffer.mjs-to-internals branch September 14, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants