Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support deno 2.0 by shimming __dirname as import.meta.dirname & __filename as import.meta.filename #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mash8
Copy link

@mash8 mash8 commented Nov 5, 2024

No description provided.

@eliassjogreen
Copy link
Member

I would prefer if you could instead shim __filename as a global in the files where they are needed instead of search-and-replacing them? Mostly just a security measure because it is close to impossible to review binary/minified files like those edited.

@mash8 mash8 changed the title chore: support deno 2.0 by replacing __dirname -> import.meta.dirname & __filename -> import.meta.filename chore: support deno 2.0 by shimming __dirname as import.meta.dirname & __filename as import.meta.filename Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants