Skip to content

Commit

Permalink
Re-apply #3538 - remove -T argument from ruby linter (#3951)
Browse files Browse the repository at this point in the history
The `-T` option (for "taint checking") was deprecated in ruby 2.7
and removed entirely in ruby 3.0. This causes the linter to fail
entirely for users of ruby 3.0.

This was reported in #3537, and then fixed in #3538 - but it seems as
though in 9fe7b1f, it was accidentally
and entirely undone.

This commit is essentially identical to #3538, aside from a path change
for the tests.
  • Loading branch information
ahayworth authored Oct 22, 2021
1 parent 9b5a358 commit 95ba789
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ale_linters/ruby/ruby.vim
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ call ale#Set('ruby_ruby_executable', 'ruby')
call ale#linter#Define('ruby', {
\ 'name': 'ruby',
\ 'executable': {b -> ale#Var(b, 'ruby_ruby_executable')},
\ 'command': '%e -w -c -T1 %t',
\ 'command': '%e -w -c %t',
\ 'output_stream': 'stderr',
\ 'callback': 'ale#handlers#ruby#HandleSyntaxErrors',
\})
4 changes: 2 additions & 2 deletions test/linter/test_ruby.vader
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ After:
call ale#assert#TearDownLinterTest()

Execute(The default command should be correct):
AssertLinter 'ruby', ale#Escape('ruby') . ' -w -c -T1 %t'
AssertLinter 'ruby', ale#Escape('ruby') . ' -w -c %t'

Execute(The executable should be configurable):
let g:ale_ruby_ruby_executable = 'foobar'

AssertLinter 'foobar', ale#Escape('foobar') . ' -w -c -T1 %t'
AssertLinter 'foobar', ale#Escape('foobar') . ' -w -c %t'

0 comments on commit 95ba789

Please sign in to comment.