-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -relative
option to ALESymbolSearch
#2255
Add -relative
option to ALESymbolSearch
#2255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this too. 👍 I wouldn't worry about tsserver
just yet. I might have a go at implementing symbol search for tsserver
later. See my comments here.
I think this is generally good, so you can update the documentation for the command to mention the new switch.
@w0rp What's the best way to request another review after change requests are addressed? |
Check out 19cc724 and examples in |
If you wait, I'll look at the pull request eventually. |
Gotcha, didn't mean to nag. It just isn't clear what state the PR is in after a change request since it stays as "Changes Requested". More of a GitHub issue, I suppose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👌
I added the
-relative
option to ALESymbolSearch, and the associated test.However, I only use TSServer, which doesn't seem to be implemented for ALESymbolSearch, so I'm unable to actually test the
-relative
option IRL. I kept changes minimal, and the existing tests pass. But I would certainly prefer a quick real-world test to confirm.