clangcheck: Add -fno-color-diagnostics (closes #2188) #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rp
requested changes
Sep 20, 2019
ale_linters/cpp/clangcheck.vim
Outdated
| @@ -20,7 +20,7 @@ function! ale_linters#cpp#clangcheck#GetCommand(buffer) abort | |||
| " being generated. These are only added if no build directory can be | |||
| " detected. | |||
| return '%e -analyze %s' | |||
| \ . (empty(l:build_dir) ? ' -extra-arg -Xclang -extra-arg -analyzer-output=text' : '') | |||
| \ . (empty(l:build_dir) ? ' --extra-arg="-Xclang" --extra-arg="-analyzer-output=text" --extra-arg="-fno-color-diagnostics"': '') | |||
There was a problem hiding this comment.
I reckon it's worth removing the double quotes here, as double quotes can sometimes break commands on Windows. Processing double quotes in a shell in Windows is the responsibility of the command instead of the shell, which causes issues where you sometimes end up passing "foo" to a Windows program instead of foo.
Also change to the modern --extra-arg syntax.
elebow
force-pushed
the
clangcheck-no-color-diagnostics
branch
from
f3b3ab7 to
6260256
Compare
w0rp
approved these changes
Oct 28, 2019
|
Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change to the modern
--extra-argsyntax.clang has supported
-fno-color-diagnosticsfor at least ten years: llvm-mirror/clang@a46c71aThis works on my machine, but I don't use clang often so a second tester would be appreciated.