Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possiblity to add extra psalm options #2819

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

greg0ire
Copy link
Contributor

@greg0ire greg0ire commented Oct 7, 2019

Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!

Maybe not at first but you can't prove it 😛

This allows me to use let g:ale_psalm_langserver_options = '--config="$HOME/.config/psalm/psalm.xml"'

@greg0ire greg0ire marked this pull request as ready for review October 7, 2019 21:28
@w0rp w0rp merged commit e259dd5 into dense-analysis:master Oct 29, 2019
@w0rp
Copy link
Member

w0rp commented Oct 29, 2019

Cheers! 🍻

Sorry about the delay. I'll get to everything when I'm able.

@greg0ire greg0ire deleted the psalm_extra_options branch October 29, 2019 17:56
@greg0ire
Copy link
Contributor Author

No worries! :)

@w0rp
Copy link
Member

w0rp commented Aug 29, 2020

I just noticed that all of the options for psalm aren't properly named, so I'm going to change them all to ale_php_psalm_.... Update your settings if you use those options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants