Alias ps1 filetype to powershell

[kevinoid]

Thanks for writing a linter for PSScriptAnalyzer @zigford! I was surprised that it isn't used by default with vim-ps1 due to requiring manual configuration to alias the ps1 filetype to powershell. Is there a reason you chose not to include it in s:default_ale_linter_aliases?

Since vim-ps1 is a popular (the only?) PowerShell ftplugin and there do not appear to be any other uses of the ps1 filetype on vim.org, this seems like a safe and reasonable default. This PR would add it, assuming there wasn't a specific reason to avoid it.

Thanks again,
Kevin

[zigford]

Hi @kevinoid I used powershell over ps1 as I didn't agree on vim-ps1's decision to use ps1 as the filetype name of powershell scripts. It doesn't fit with how every other language names their filetypes. Ie, python filetype is not named after it's extension, nor is ruby.

I've also made https://github.com/zigford/vim-powershell in the hopes that others will contribute and we can have sane powershell + vim functionality.

Anyway, I digress. The proper answer is that I did not know about s:default_ale_linter_aliases, so I think this will be a welcome change and make the current powershell linting easier to discover in ale.

[kevinoid]

Thanks @zigford! Makes sense to me. I'm looking forward to checking out vim-powershell.

@w0rp: I think it's safe to merge. (If you approve, of course.)

[stale]

This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See :help ale-dev for information on writing tests.
If your pull request is good to merge, bother w0rp or another maintainer again, and get them to merge it.

[kevinoid]

@w0rp I think this PR is good to merge and not stale.

[w0rp]

Yep, this is good. The bot is doing its job correctly.

[w0rp]

Cheers! 🍻

[kevinoid]

Yes indeed. Thanks for reviewing and merging it! 🥂