eslint: Use cwd from executable location to fix nested projects #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path searching in ale#node#FindExecutable() will be useful for eslint. Refactor it into a separate function so it can be used without regard for the state of the _use_global and _executable variables. Signed-off-by: Kevin Locke <[email protected]>
Using the nearest directory with node_modules does not work correctly for nested projects where the eslint dependencies are in the outer project. For example: dense-analysis#3143 (comment) Adopt the behavior of SublimeLinter, which runs from project_root determined by the presence of the eslint executable in node_modules/.bin (or eslint in dependencies/devDependencies of package.json, which we can add later as necessary). See [NodeLinter#find_local_executable]. [NodeLinter#find_local_executable]: https://github.com/SublimeLinter/SublimeLinter/blob/056e6f6/lint/base_linter/node_linter.py#L109 Signed-off-by: Kevin Locke <[email protected]>
|
this works perfectly for my setup in #3143 (comment) thanks a ton for working on this! |
w0rp
approved these changes
Jul 8, 2020
|
Cheers! 🍻 |
w0rp
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Split FindNearestExecutable from FindExecutable The path searching in ale#node#FindExecutable() will be useful for eslint. Refactor it into a separate function so it can be used without regard for the state of the _use_global and _executable variables. Signed-off-by: Kevin Locke <[email protected]> * eslint: Set project root from local executable Using the nearest directory with node_modules does not work correctly for nested projects where the eslint dependencies are in the outer project. For example: #3143 (comment) Adopt the behavior of SublimeLinter, which runs from project_root determined by the presence of the eslint executable in node_modules/.bin (or eslint in dependencies/devDependencies of package.json, which we can add later as necessary). See [NodeLinter#find_local_executable]. [NodeLinter#find_local_executable]: https://github.com/SublimeLinter/SublimeLinter/blob/056e6f6/lint/base_linter/node_linter.py#L109 Signed-off-by: Kevin Locke <[email protected]>
|
Thanks for reviewing and merging @w0rp! 🥂 |
|
I am having a problem which is related to this MR. Should I open a new issue, or ask the questions here? In summary, running eslint from my source code directory is desired, but this MR introduced changing directory to the location of eslint (thereby using the wrong configuration, instead of my projects eslint configuration) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2937, ESLint is run from the nearest directory with
node_modules. This does not work correctly for nested projects where the eslint and any required config/plugin packages are installed in the outer project. For example: #3143 (comment)Adopt the behavior of SublimeLinter, which runs from
project_rootdetermined by the presence of theeslintexecutable innode_modules/.bin(oreslintindependencies/devDependenciesofpackage.json, which we can add later as necessary). See SublimeLinter/SublimeLinter#1649 andNodeLinter#find_local_executable.Thanks for considering,
Kevin
cc: @w0rp, @joeldodge79