Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix for #3320. I went with a solution where if the macro expansion error happens in the current file, set
lnum
andcol
accordingly. If the error happens in some other file, there's really no easy way to know on which line the error should be placed on in the current file, so just letlnum
be 0.For example, consider this situation:
The error reported by GCC would be
To figure out on which line in
c.cpp
we should place the error we would need to go through the different headers inc.cpp
until we findheader2.h
. I think that's a bit overkill, and just letting thelnum
be zero with thetext
Error found in macro expansion. See :ALEDetail
is (hopefully) good enough.