Have c_parse_makefile look for GNUmakefile as well #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefiles using GNU-make features might be called "GNUmakefile" instead of "Makefile". This commit teaches the `c_parse_makefile` feature to look for a GNUmakefile file if a Makefile is not present.
hsanson
requested changes
Feb 4, 2021
There was a problem hiding this comment.
Adding tests would be good but I am not too familiar with C tests. At least I think replicating the tests in test_c_flag_parsing.vader for the ale#c#GetMakeCommand() method should be added. Using a different sample project than makefile_project that uses the GNUMakefile instead of a Makefile.
|
Adding another test for |
|
A quick question... Is there a way to run the test suite without using Docker? The documentation mentions using docker for the test suite but Docker is a bit tricky to install on Fedora, which is what I'm using now. |
hsanson
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefiles using GNU Make features might be called "GNUmakefile" instead
of "Makefile". This commit teaches the
c_parse_makefilefeature tolook for a GNUmakefile file if a Makefile is not present.
I'm putting this in a separate PR from #3574, because it's an unrelated feature request.
Again, I'm not sure if this needs adding tests as well. If it does then I can try to come back later to do that.