ALERename: Fix an issue with unlisted buffers

[jeremija]

After calling ALERename on certain symbols, some files would be incorrectly replaced. The whole file would be truncated, and the only contents would be the new variable name.

I was able to consistently reproduce it using the following configuration:

let g:ale_linters = {
\  'go': ['gopls', 'golangci-lint'],
\}

Whenever I rename a symbol in myfile.go which is also referenced from an unopened file myfile_test.go, the whole myfile_test.go is truncated.

I tracked it down to bufnr('/path/to/myfile_test.go') returning number for a buffer that I never opened.

I later noticed that this buffer was unlisted (visible only via :ls!). So there must be something in the golangci-lint linter that opens this file in the background.

This fix adds a check for hidden buffers before applying code actions.

Closes #3781

[jeremija]

cc: @w0rp @liskin @daliusd

[daliusd]

Looks good to me. That’s all I can do however.

[liskin]

@davidatbu Is this the problem you encountered in #3478 (comment)?

(I never use :bd so that's why I never encountered it.)

[liskin]

Good catch!

Should the if a:should_save || l:buffer < 0 line become if a:should_save || !l:is_opened?

[jeremija]

Hey all, thanks for taking a look at this so quickly! After I made this change yesterday, I realized we can further improve the rename operation, since there are some cases when renaming simply fails after doing it twice.

So I'm going to close this MR in favor of #3783 - I'd appreciate if you could have a look at the change there 🙇‍♂️

[dnaaun]

@liskin, this was exactly the problem i described in that comment you mentioned! Hope it gets fixed soon.

[jeremija]

Thanks @davidatbu, I'd appreciate if you could have a look at MR #3783 to see if you can find any bugs?

I think it should all be resolved now, but it's still possible there are some corner cases I haven't tested.

[dnaaun]

Thanks for your contributions. I'm currently toying with Neovim's built in LSP, so i don't have the bandwidth to try this out, but if I ever revert back to ALE, i will be sure to let you know.

…

On Sun, Jun 27, 2021, 9:01 PM Jerko Steiner ***@***.***> wrote: Thanks @davidatbu <https://github.com/davidatbu>, I'd appreciate if you could have a look at MR #3783 <#3783> to see if you can find any bugs? I think it should all be resolved now, but it's still possible there are some corner cases I haven't tested. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3782 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMQIHCZIR4VHL74GORVFG7DTU5RRHANCNFSM47LO723Q> .