Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] CircleCI: skip checking for new tool version #3902

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

goetzc
Copy link
Contributor

@goetzc goetzc commented Sep 15, 2021

This way the tool runs a bit faster and we don't create unneeded network requests. Don't know if there are other network requests still occurring.

This way the tool runs a bit faster and we don't create unneeded network requests. Don't know if there are other network requests still occurring.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Can we assume that flag is available independently of circleci version? Just wondering if this change would break ALE for people stuck with older versions of circleci.

@goetzc
Copy link
Contributor Author

goetzc commented Sep 16, 2021

That is a good question.

Looks like the check was introduced in version v0.1.4005 on 13 Nov 2018, like three years ago.

And later they introduced another option to disable the command using an environment variable, CIRCLECI_CLI_SKIP_UPDATE_CHECK in version v0.1.8764 on 16 Jul 2020, last year.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, change looks good.

@hsanson hsanson merged commit 2f72a3e into dense-analysis:master Sep 17, 2021
@goetzc goetzc deleted the patch-1 branch November 9, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants