Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deno lsp for javascript #3924

Merged
merged 5 commits into from
Oct 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ale_linters/javascript/deno.vim
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
" Author: Arnold Chand <[email protected]>
" Description: Deno lsp linter for JavaScript files.

call ale#linter#Define('javascript', {
\ 'name': 'deno',
\ 'lsp': 'stdio',
\ 'executable': function('ale#handlers#deno#GetExecutable'),
\ 'command': '%e lsp',
\ 'project_root': function('ale#handlers#deno#GetProjectRoot'),
\ 'initialization_options': function('ale#handlers#deno#GetInitializationOptions'),
\})
5 changes: 5 additions & 0 deletions doc/ale-javascript.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ To this: >
/path/foo/bar/.eslintrc.js # extends: ["/path/foo/.base-eslintrc.js"]
<

===============================================================================
deno *ale-javascript-deno*

Check the docs over at |ale-typescript-deno|.

===============================================================================
eslint *ale-javascript-eslint*

Expand Down
1 change: 1 addition & 0 deletions doc/ale-supported-languages-and-tools.txt
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ Notes:
* `javalsp`
* `uncrustify`
* JavaScript
* `deno`
* `eslint`
* `fecs`
* `flow`
Expand Down
2 changes: 1 addition & 1 deletion doc/ale-typescript.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ g:ale_deno_lsp_project_root *g:ale_deno_lsp_project_root*
executing the following steps in the given order:

1. Find an ancestor directory containing a tsconfig.json.
2. Find an ancestory irectory containing a .git folder.
2. Find an ancestory directory containing a .git folder.
3. Use the directory of the current buffer (if the buffer was opened from
a file).

Expand Down
1 change: 1 addition & 0 deletions doc/ale.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2813,6 +2813,7 @@ documented in additional help files.
eclipselsp............................|ale-java-eclipselsp|
uncrustify............................|ale-java-uncrustify|
javascript..............................|ale-javascript-options|
deno..................................|ale-javascript-deno|
eslint................................|ale-javascript-eslint|
fecs..................................|ale-javascript-fecs|
flow..................................|ale-javascript-flow|
Expand Down
1 change: 1 addition & 0 deletions supported-tools.md
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ formatting.
* [javalsp](https://github.com/georgewfraser/vscode-javac)
* [uncrustify](https://github.com/uncrustify/uncrustify)
* JavaScript
* [deno](https://deno.land/)
* [eslint](http://eslint.org/)
* [fecs](http://fecs.baidu.com/)
* [flow](https://flowtype.org/)
Expand Down
79 changes: 79 additions & 0 deletions test/linter/test_javascript_deno_lsp.vader
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
Before:
let g:ale_deno_importMap = 'import_map.json'
let g:ale_deno_unstable = 0
let g:ale_deno_executable = 'deno'
let g:ale_deno_lsp_project_root = ''

runtime autoload/ale/handlers/deno.vim
call ale#assert#SetUpLinterTest('javascript', 'deno')

After:
call ale#assert#TearDownLinterTest()

Execute(Should set deno lsp for JavaScript projects using stable Deno API):
AssertLSPOptions {
\ 'enable': v:true,
\ 'lint': v:true,
\ 'unstable': v:false,
\ 'importMap': ''
\}

Execute(Should set deno lsp using unstable Deno API if enabled by user):
let g:ale_deno_unstable = 1

AssertLSPOptions {
\ 'enable': v:true,
\ 'lint': v:true,
\ 'unstable': v:true,
\ 'importMap': ''
\}

Execute(Should set the default importMap filepath):
call ale#test#SetFilename('../test-files/javascript_deno/main.js')

AssertLSPOptions {
\ 'enable': v:true,
\ 'lint': v:true,
\ 'unstable': v:false,
\ 'importMap': ale#path#Simplify(g:dir . '/../test-files/javascript_deno/import_map.json')
\}

Execute(Should set the importMap filepath from user defined importMap):
let g:ale_deno_importMap = 'custom_import_map.json'
call ale#test#SetFilename('../test-files/javascript_deno/main.js')

AssertLSPOptions {
\ 'enable': v:true,
\ 'lint': v:true,
\ 'unstable': v:false,
\ 'importMap': ale#path#Simplify(g:dir . '/../test-files/javascript_deno/custom_import_map.json')
\}

Execute(Should set the importMap filepath from user defined importMap with unstable API):
let g:ale_deno_importMap = 'custom_import_map.json'
let g:ale_deno_unstable = 1
call ale#test#SetFilename('../test-files/javascript_deno/main.js')

AssertLSPOptions {
\ 'enable': v:true,
\ 'lint': v:true,
\ 'unstable': v:true,
\ 'importMap': ale#path#Simplify(g:dir . '/../test-files/javascript_deno/custom_import_map.json')
\}

Execute(Should find project root containing tsconfig.json):
call ale#test#SetFilename('../test-files/javascript_deno/main.js')

AssertLSPLanguage 'javascript'
AssertLSPProject ale#path#Simplify(g:dir . '/../test-files/javascript_deno')

Execute(Should use user-specified project root):
let g:ale_deno_lsp_project_root = '/'

call ale#test#SetFilename('../test-files/javascript_deno/main.js')

AssertLSPLanguage 'javascript'
AssertLSPProject '/'

Execute(Check Deno LSP command):
AssertLinter 'deno', ale#Escape('deno') . ' lsp'
3 changes: 3 additions & 0 deletions test/test-files/javascript_deno/custom_import_map.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"imports": {}
}
3 changes: 3 additions & 0 deletions test/test-files/javascript_deno/import_map.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"imports": {}
}
1 change: 1 addition & 0 deletions test/test-files/javascript_deno/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
console.log("Hello World");
16 changes: 16 additions & 0 deletions test/test-files/javascript_deno/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"compilerOptions": {
"allowJs": true,
"esModuleInterop": true,
"experimentalDecorators": true,
"inlineSourceMap": true,
"isolatedModules": true,
"jsx": "react",
"lib": ["deno.window"],
"module": "esnext",
"strict": true,
"target": "esnext",
"useDefineForClassFields": true
},
"includes": ["main.js"]
}