Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVRA linting #3950

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Add support for AVRA linting #3950

merged 7 commits into from
Nov 15, 2021

Conversation

UtkarshVerma
Copy link
Contributor

This PR adds support for AVR assembly linting through avra.

This is the linter in action:
Peek 2021-10-21 07-43

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for the command and handle methods. Check the test/linter and test/handler folders for many examples.

ale_linters/avra/avra.vim Outdated Show resolved Hide resolved
ale_linters/avra/avra.vim Outdated Show resolved Hide resolved
@UtkarshVerma
Copy link
Contributor Author

Also, if you're merging this PR, could you please consider labelling this PR as 'hacktoberfest-accepted'?

@UtkarshVerma
Copy link
Contributor Author

@hsanson I have fixed the tests. Everything should be fine now.

@hsanson
Copy link
Contributor

hsanson commented Nov 12, 2021

Make sure to add and align these two documents:

  • supported-tools.md and doc/ale-supported-languages-and-tools.txt

Tests fail because the new linter seems to be missing or out of order in one of them.

@UtkarshVerma UtkarshVerma requested a review from hsanson November 14, 2021 18:36
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@hsanson hsanson merged commit 1e0e76b into dense-analysis:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants