Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit config #1600

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Update pre-commit config #1600

merged 2 commits into from
Jan 10, 2024

Conversation

EvanParish
Copy link

@EvanParish EvanParish commented Jan 10, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This is just a quick config change to enable/fix talisman in our pre-commit config and update the pre-commit versions.

I will walk the team through the setup, it's very simple.

issue #N/A

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)

  • Tested locally by adding "secrets" and running pre-commit
    • caught the secret values with talisman
    • caught the secret values with bandit
    • fixed formatting with ruff

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured the latest master is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column

@EvanParish EvanParish self-assigned this Jan 10, 2024
@EvanParish EvanParish requested a review from a team as a code owner January 10, 2024 21:00
@EvanParish EvanParish merged commit 3aef50a into master Jan 10, 2024
5 checks passed
@EvanParish EvanParish deleted the pre-commit-setup branch January 10, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants