Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1501 [v3] Removed Extra Decorator #1621

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

k-macmillan
Copy link
Member

@k-macmillan k-macmillan commented Jan 29, 2024

Description

Removed extra decorator that prevented the Celery task from running.

Added some unrelated, but required, unit test fixes and locked pytest + moto to their last major versions due to breaking changes.

issue #1501

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only

How Has This Been Tested?

Deployed and tested sending an email with v3. Succeeded.

image

image

image

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured the latest master is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column

@k-macmillan k-macmillan self-assigned this Jan 29, 2024
@k-macmillan k-macmillan marked this pull request as ready for review January 29, 2024 20:51
@k-macmillan k-macmillan requested a review from a team as a code owner January 29, 2024 20:51
@k-macmillan k-macmillan merged commit 7795d6a into master Jan 30, 2024
13 checks passed
@k-macmillan k-macmillan deleted the 1501-send-email-with-post-request branch January 30, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants