Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1819 Add fields to VAProfile cache table #1825

Merged
merged 4 commits into from
May 29, 2024

Conversation

mchlwellman
Copy link

@mchlwellman mchlwellman commented May 29, 2024

Description

This PR adds participant_id and has_duplicate_mappings, which were previously in a DynamoDB table, into the Postgres va_profile_local_cache table.

issue #1819

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured the latest master is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column

@mchlwellman mchlwellman self-assigned this May 29, 2024
@mchlwellman mchlwellman added the internal For internal updates label May 29, 2024
@mchlwellman mchlwellman marked this pull request as ready for review May 29, 2024 13:15
@mchlwellman mchlwellman requested a review from a team as a code owner May 29, 2024 13:15
Copy link

@MackHalliday MackHalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif

@mchlwellman mchlwellman merged commit a9b3258 into master May 29, 2024
15 checks passed
@mchlwellman mchlwellman deleted the 1819-add-fields-va-profile-table branch May 29, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For internal updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants