forked from cds-snc/notification-api
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1897 - database migration to change VAProfile and Participant IDs to big integers #1901
Merged
EvanParish
merged 14 commits into
master
from
1897-participant_id_column_throws_NumericValueOutOfRange_error
Aug 6, 2024
Merged
#1897 - database migration to change VAProfile and Participant IDs to big integers #1901
EvanParish
merged 14 commits into
master
from
1897-participant_id_column_throws_NumericValueOutOfRange_error
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackHalliday
changed the title
Squash #1897 - participant_id updated to biginit
#1897 - participant_id updated to biginit
Aug 2, 2024
… file paired down
MackHalliday
changed the title
#1897 - participant_id updated to biginit
#1897 - participant_id and va_profile_id in VAProfileLocalCache updated to biginit
Aug 5, 2024
MackHalliday
changed the title
#1897 - participant_id and va_profile_id in VAProfileLocalCache updated to biginit
#1897 - participant_id and va_profile_id in VAProfileLocalCache updated to BigInt
Aug 5, 2024
cris-oddball
requested changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please test the migration downgrade and indicate this was tested in the PR's description.
… cannot be converted to INT
…alueOutOfRange_error
EvanParish
approved these changes
Aug 6, 2024
kalbfled
approved these changes
Aug 6, 2024
cris-oddball
approved these changes
Aug 6, 2024
EvanParish
deleted the
1897-participant_id_column_throws_NumericValueOutOfRange_error
branch
August 6, 2024 15:43
cris-oddball
changed the title
#1897 - participant_id and va_profile_id in VAProfileLocalCache updated to BigInt
#1897 - database migration to change VAProfile and Participant IDs to big integers
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
issue #1897
participant_id
andva_profile_id
from Int to BigInt to avoid NumericValueOutOfRange error when updating VA Profile ID with a given Participant ID in the MPI lookup lambdava_profile_id
values that cannnot be converted back to Int from BigIntparticipant_id
to (-1) if theparticipant_id
cannot be convert back to Int to BigIntType of change
Please check the relevant option(s).
How Has This Been Tested?
Test Upgrade
participant_id
that used to throw errorsTested Downgrade
participant_id
of 9223372036854775800 and another with ava_profile_id
of 9223372036854775800.Then we ran downgrade. The
participant_id
row was updated to -1 and the va_profile_id row was deleted.Checklist