Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2013 - Add callback url field to Notifications table #2027

Closed
wants to merge 9 commits into from

Conversation

MackHalliday
Copy link

@MackHalliday MackHalliday commented Oct 1, 2024

Description

  • Adding a callback_url column to the Notification table with upgrade and downgrade

issue #2013

How Has This Been Tested?

Deploy to Dev OK

Screenshot from DEV DB - Notification Table
Screenshot 2024-10-01 at 4 14 27 PM

Downgrade in DEV OK

Screenshot from DEV DB AFTER Downgrade - Notification Table
Screenshot 2024-10-01 at 4 27 06 PM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@MackHalliday MackHalliday self-assigned this Oct 1, 2024
@MackHalliday MackHalliday marked this pull request as ready for review October 1, 2024 20:28
@MackHalliday MackHalliday requested a review from a team as a code owner October 1, 2024 20:28
@MackHalliday MackHalliday marked this pull request as draft October 1, 2024 20:30
@k-macmillan k-macmillan deleted the 2013-add-database-field-callback-url branch November 29, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants