Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1979 - add notification column to VA Profile Local Cache #2076

Merged

Conversation

MackHalliday
Copy link

@MackHalliday MackHalliday commented Oct 22, 2024

Description

issue #1979

  • This ticket requires that the notification_id from the send Comp and Pen Opt-In confirmation be saved to the va_profile_local_cache table.
  • I am doing the migration work as a separate PR to make deploying and reviewing easier.
  • The rest of the work will be finished in this ticket.

How Has This Been Tested?

Migration OK

Screenshot 2024-10-22 at 2 17 49 PM

Downgrade OK

Screenshot 2024-10-22 at 2 37 49 PM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@MackHalliday MackHalliday self-assigned this Oct 22, 2024
@MackHalliday MackHalliday marked this pull request as ready for review October 22, 2024 18:38
@MackHalliday MackHalliday requested a review from a team as a code owner October 22, 2024 18:38
@MackHalliday MackHalliday merged commit 97a3356 into main Oct 22, 2024
14 checks passed
@MackHalliday MackHalliday deleted the 1979-add-notification-column-to-va-profile-local-cache-V2 branch October 22, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants