Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2159 - Update Total Time For Twilio Delivery Status #2168

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

k-macmillan
Copy link
Member

@k-macmillan k-macmillan commented Dec 6, 2024

Description

Twilio delivery status can come in with a negative timestamp due to only having minute granularity. This only affects our logging but has been updated so our internal charts and logs are not confusing.

issue #2159

How Has This Been Tested?

Wrote a new test. Deployed.
Ran requests using Twilio at various times to attempt to trigger a negative number, all were positive:
image

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@k-macmillan k-macmillan self-assigned this Dec 6, 2024
@k-macmillan k-macmillan marked this pull request as ready for review December 6, 2024 17:27
@k-macmillan k-macmillan requested a review from a team as a code owner December 6, 2024 17:27
Copy link
Member

@kalbfled kalbfled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. You could also have log_notification_total_time return the time to facilitate testing.

@k-macmillan k-macmillan merged commit e15b799 into main Dec 6, 2024
13 checks passed
@k-macmillan k-macmillan deleted the 2159-negative-twilio-time branch December 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants