#2130 - Add path to environment vars file S3 upload #2176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the path
/notification-api
to the uploaded environment S3 object. We are doing this to be able to differentiate API env vars from ENP env vars.issue #2130
How Has This Been Tested?
This image shows the uploaded dev.env object under the path
notification-api/
.This image shows the dev task definition pulling from that new location.
This image shows a grep output that validates every location where the bucket name is being used has the updated path.
Last image shows grepping in the
.github/
directory, paths have been added to all S3 upload calls:Additionally, regression passed and all tests passed.
Checklist