Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2130 - Add path to environment vars file S3 upload #2176

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

coreycarvalho
Copy link

@coreycarvalho coreycarvalho commented Dec 11, 2024

Description

This PR adds the path /notification-api to the uploaded environment S3 object. We are doing this to be able to differentiate API env vars from ENP env vars.

issue #2130

How Has This Been Tested?

This image shows the uploaded dev.env object under the path notification-api/.
image

This image shows the dev task definition pulling from that new location.
image

This image shows a grep output that validates every location where the bucket name is being used has the updated path.
image

Last image shows grepping in the .github/ directory, paths have been added to all S3 upload calls:
image

Additionally, regression passed and all tests passed.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@coreycarvalho coreycarvalho changed the title Add path to environment vars file S3 upload #2130 - Add path to environment vars file S3 upload Dec 11, 2024
@coreycarvalho coreycarvalho self-assigned this Dec 11, 2024
@coreycarvalho coreycarvalho marked this pull request as ready for review December 11, 2024 17:03
@coreycarvalho coreycarvalho requested a review from a team as a code owner December 11, 2024 17:03
@coreycarvalho coreycarvalho merged commit 5ca1c61 into main Dec 11, 2024
13 checks passed
@coreycarvalho coreycarvalho deleted the 2130-env-file-pathing branch December 11, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants