Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEAM-1420 - Updating API Key generation #2179

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

MackHalliday
Copy link

@MackHalliday MackHalliday commented Dec 12, 2024

Description

  • Updating api key generation

Issue #TEAM-1420

How Has This Been Tested?

Deployed to DEV OK

Tested can create new service API-Key

Screenshot 2024-12-13 at 10 21 13 AM

Test new service API-Key can be used to send Email Notification

Screenshot 2024-12-13 at 10 52 31 AM

Test new service API-Key can be revoked

Screenshot 2024-12-13 at 11 03 27 AM Screenshot 2024-12-13 at 11 03 42 AM

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@MackHalliday MackHalliday self-assigned this Dec 12, 2024
@MackHalliday MackHalliday changed the title #1420 - api key update #1420 - Updating API Key generation Dec 13, 2024
@MackHalliday MackHalliday marked this pull request as ready for review December 13, 2024 16:48
@MackHalliday MackHalliday requested a review from a team as a code owner December 13, 2024 16:48
@MackHalliday MackHalliday changed the title #1420 - Updating API Key generation TEAM-1420 - Updating API Key generation Dec 13, 2024
cris-oddball
cris-oddball previously approved these changes Dec 13, 2024
kalbfled
kalbfled previously approved these changes Dec 13, 2024
tests/app/dao/test_api_key_dao.py Outdated Show resolved Hide resolved
@EvanParish EvanParish merged commit 906d54a into main Dec 13, 2024
5 checks passed
@EvanParish EvanParish deleted the 1420-api-key-update branch December 13, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants