Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1350 Use America/New_York time zone by default #2193

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

kalbfled
Copy link
Member

Description

These changes replace all instances of the timezone America/Toronto with America/New_York.

issue #1350

How Has This Been Tested?

All unit tests continue to pass, and grep -rni Toronto no longer returns any hits.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled added the patch label Dec 19, 2024
@kalbfled kalbfled self-assigned this Dec 19, 2024
@kalbfled kalbfled marked this pull request as ready for review December 23, 2024 17:04
@kalbfled kalbfled requested a review from a team as a code owner December 23, 2024 17:04
@kalbfled kalbfled merged commit ad64f20 into main Dec 23, 2024
13 checks passed
@kalbfled kalbfled deleted the 1350-ny-timezone branch December 23, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants