Running yarn install before running the update checkoer
#11011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,12 +101,21 @@ def npm_files | |||
| fetched_npm_files | |||
| end | |||
|
|
|||
| def run_yarn_install | |||
| Dir.chdir("repo") do | |||
| # --refresh-lockfile Refresh the package metadata stored in the lockfile | |||
There was a problem hiding this comment.
Any reason why we are not using the Helper.Subprocess method?
Also, can we add tests?
There was a problem hiding this comment.
Based on the analysis, yarn immutable install is only creating .yarn/cache directory on the repo directory. So I have updated fix and test accordingly.
With this, I ran the cli and ensured, Customer reported issue is fixed
thavaahariharangit
force-pushed
the
harry/run-yarn-install-before-update-checker
branch
from
f6cb157 to
bf310e6
Compare
|
TODO: Junit needs to be added. |
abdulapopoola
approved these changes
Nov 27, 2024
thavaahariharangit
deleted the
harry/run-yarn-install-before-update-checker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Rel : https://github.com/github/dependabot-updates/issues/7169
Root cause of above issue is
yarn add/upgrade <package-name>@versionis failingCreating a cache folder under .yarn file fixes this issue.
Anything you want to highlight for special attention from reviewers?
I have ran the cli against the repo where I recreated the error and solved it by this update.
How will you know you've accomplished your goal?
I have ran the cli against the repo where I recreated the error and solved it by this update.
Checklist