Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorbet types to bundler dependency_source.rb #11539

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amazimbe
Copy link
Contributor

What are you trying to accomplish?

Add sorbet typing to bundler/helpers/v2/lib/functions/dependency_source.rb .

How will you know you've accomplished your goal?

All CI checks should still pass following these changes.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Feb 10, 2025
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Feb 10, 2025
@amazimbe amazimbe force-pushed the amazimbe/srb-typecheck-bundler/dependency_source branch from 381da5d to 1c7b023 Compare February 10, 2025 15:41
@amazimbe amazimbe force-pushed the amazimbe/srb-typecheck-bundler/dependency_source branch from 1c7b023 to fa67510 Compare February 10, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant