Match new CVSS score failure exit code on Dependency-Check v8 or higher #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidojw
changed the title
|
Hi @ejohn20, this extension not supporting the breaking change from |
ejohn20
approved these changes
Jan 18, 2023
|
Merging to the develop branch so I can test the dev version of the extension before releasing. |
|
I'm unable to reproduce this in my demo pipelines. I have merged this and released in v6.1.0. Please verify that the fix is working as expected. |
|
It happened when setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
v8.0.0, the CVSS score failure exit code was changed from 1 to 15 (PR: jeremylong/DependencyCheck#4511), which is why this extension now fails instead of warns on these because it still expects an exit code of 1.This PR adds support for this by comparing the exitCode with 1 if the input dependency-check version starts with
[0-7]., and otherwise a 15.