Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more german nobility titles #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added more german nobility titles #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions nameparser/config/titles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,15 @@
TITLES = FIRST_NAME_TITLES | set([
"attaché",
"chargé d'affaires",
"chargé d’affaires",
"king's",
"king’s",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion from my side would be to normalize the apostrophes and dashes prior to matching against these lists. There are too many variations to capture them all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely agreed; I did not take the time to take a look if this happens already somewhere in the code… Obviously there's a bunch of misused characters that might function as apostrophes, even if we only take into account latin script, e.g. '’‘' and the backtick that ` creates the <code/>. Search the unicode.org charts for all other apostrophes for other writing systems

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would benefit from this MR as I will have to deal with German names soon. Would it be reasonable to move the debate about apostrophes to a dedicated issue so that the rest of the contribution could be released?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. The PR is quite old. So I guess it needs to have conflicts resolved etc.

"marchioness",
"marquess",
"marquis",
"marquise",
"queen's",
"queen’s",
'10th',
'1lt',
'1sgt',
Expand Down Expand Up @@ -254,6 +257,7 @@
'ecologist',
'economist',
'editor',
'edler',
'edmi',
'edohen',
'educator',
Expand All @@ -269,6 +273,7 @@
'entertainer',
'entrepreneur',
'envoy',
'erzbischof',
'essayist',
'evangelist',
'excellency',
Expand All @@ -288,7 +293,12 @@
'foreign',
'forester',
'founder',
'fräulein',
'freifrau',
'freiherr',
'friar',
'fürst',
'fürsterzbischof',
'gaf',
'gen',
'general',
Expand All @@ -301,6 +311,7 @@
'graf',
'grand',
'group',
'großfürst',
'guitarist',
'guru',
'gyani',
Expand All @@ -311,6 +322,7 @@
'heiress',
'her',
'hereditary',
'herzog',
'high',
'highness',
'his',
Expand Down Expand Up @@ -484,6 +496,7 @@
'principal',
'printer',
'printmaker',
'prinz',
'prior',
'private',
'pro',
Expand All @@ -506,6 +519,7 @@
'rdml',
'rear',
'rebbe',
'reichsgraf',
'registrar',
'rep',
'representative',
Expand All @@ -516,6 +530,7 @@
'reverend',
'right',
'risk',
'ritter',
'rock',
'royal',
'rt',
Expand Down