Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA] fix: stake value fix on crypto currency change #17683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vinu-deriv
Copy link
Contributor

@vinu-deriv vinu-deriv commented Nov 29, 2024

Changes:

On change of the currency stake value is changes as per new currency.
Fixed the payout disappearing issue on change of crypto currency

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 29, 2024 0:40am

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12084583634

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 53.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/Stores/Modules/Trading/trade-store.ts 0 2 0.0%
Totals Coverage Status
Change from base Build 12084193243: 0.003%
Covered Lines: 32828
Relevant Lines: 56790

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17683](https://github.com/deriv-com/deriv-app/pull/17683)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-grwt-2403stake-value-fix.binary.sx?qa_server=red.derivws.com&app_id=24078
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-grwt-2403stake-value-fix.binary.sx
- **App ID**: `24078`

Copy link
Contributor

github-actions bot commented Nov 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 41
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-grwt-2403stake-value-fix.binary.sx/

@vinu-deriv vinu-deriv marked this pull request as ready for review November 29, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants