[P2PS] / Ameerul / P2PS-4532 PA client gets logout when login

[ameerul-deriv]

Changes:

Please provide a summary of the change.

• Added is_authorize check in the useEffect before subscribing to p2p_settings as we have another authorize call in socket-general.js, and we didn't wait for that authorize check as well

Screenshots:

Please provide some screenshots of the change.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Dec 2, 2024 9:48am

[coveralls]

Pull Request Test Coverage Report for Build 12116320764

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 53.9%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/core/src/Stores/client-store.js	0	1	0.0%

Totals
Change from base Build 12113638056:	0.002%
Covered Lines:	32848
Relevant Lines:	56839

---

💛 - Coveralls

[github-actions]

A production App ID was automatically generated for this PR. (log)

• PR: [P2PS] / Ameerul / P2PS-4532 PA client gets logout when login #17699
• URLs:
  • w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-p2ps-4532-pa-client-get-d8e664.binary.sx?qa_server=red.derivws.com&app_id=32109
  • Original: https://deriv-app-git-fork-ameerul-deriv-p2ps-4532-pa-client-get-d8e664.binary.sx
• App ID: 32109

Click here to copy & paste above information.

- **PR**: [https://github.com/deriv-com/deriv-app/pull/17699](https://github.com/deriv-com/deriv-app/pull/17699)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-4532-pa-client-get-d8e664.binary.sx?qa_server=red.derivws.com&app_id=32109
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-4532-pa-client-get-d8e664.binary.sx
- **App ID**: `32109`

[github-actions]

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	34
🟧 Accessibility	70
🟢 Best practices	92
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-4532-pa-client-get-d8e664.binary.sx/

[ameerul-deriv]

will this have any impact on the user? From what yashim has explained to me, this will slow the call a little since it will check for auth first before calling mt5_login_list, but will this impact any other major flows?

[hasan-deriv]

we are already checking this.is_logged_in then why need authorized again?

[ameerul-deriv]

because for certain PA accounts, (idk why this happens) it will call this specific mt5_login_list endpoint before we authorize during login. Currently when we login, one websocket is created, and then a second is created, and this mt5_login_list gets called in the second websocket, before authorize. So we need to use WS.authorized to make sure it waits for authorized call before calling mt5_login_list