[BOT]maryia/BOT-2462/fix: Total Payout remains zero for multipliers and accumulator QS #17703
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-matskevich-deriv
requested review from
sandeep-deriv and
shafin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maryia-matskevich-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 12137602786Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-maryia-matskevich-deriv-maryia-bot-2462.binary.sx/ |
rupato-deriv
reviewed
Dec 3, 2024
rupato-deriv
reviewed
Dec 3, 2024
shafin-deriv
reviewed
Dec 3, 2024
Comment on lines
85
to
101
| const trade_options_blocks = window.Blockly.derivWorkspace | ||
| .getAllBlocks() | ||
| .filter( | ||
| b => | ||
| b.type === 'trade_definition_multiplier' || | ||
| b.type === 'trade_definition_accumulator' | ||
| ); | ||
| trade_options_blocks.forEach((trade_options_block: { selected_trade_type: string }) => { | ||
| if ( | ||
| trade_options_block.selected_trade_type === 'accumulator' || | ||
| trade_options_block.selected_trade_type === 'multiplier' | ||
| ) { | ||
| if (stats.total_payout !== bid_price && profit >= 0 && payout !== bid_price) { | ||
| stats.total_payout += bid_price; | ||
| } | ||
| } | ||
| }); |
There was a problem hiding this comment.
@maryia-matskevich-deriv we don't need to make all these changes. Let's get on a huddle with @rupato-deriv . We just need to take the bid_price out from the API response and use it like this: stats.total_payout += payout ?? bid_price ?? 0
We do not need to make all these changes.
There was a problem hiding this comment.
yes, we've checked, make sense, we can make the solution much shorter, thank you guys🙏
maryia-matskevich-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
maryia-matskevich-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
shafin-deriv
approved these changes
Dec 3, 2024
rupato-deriv
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
fix: Total Payout remains zero for multipliers and accumulator QS
Screenshots: