Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getDefaultActiveAccount() #12

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

yashim-deriv
Copy link
Collaborator

Description

  • Add getDefaultActiveAccount() which helps decide which account is default if none is selected
  • Priority is in this order: Virtual/Demo Account -> First Account -> Invalid
  • Renamed AccountInfo type to LoginInfo (more accurate name since it is basically login info obtained from OAuth redirect)

Copy link

github-actions bot commented Feb 28, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 100% 634 / 634
🔵 Statements 100% 634 / 634
🔵 Functions 100% 18 / 18
🔵 Branches 92.95% 66 / 71
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/url.utils.ts 100% 90.24% 100% 100%
Generated in workflow #23

@yashim-deriv yashim-deriv merged commit 0a80cbe into master Feb 28, 2024
1 check passed
@yashim-deriv yashim-deriv deleted the add_default_loginid_utils branch February 28, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant