[CFDS] shontzu/CFDS-4498/british-pound-sign-is-not-accepted-as-a-special-character #70
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shontzu-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
niloofar-deriv
as code owners
shontzu-deriv
changed the title
Pull Request Test Coverage Report for Build 10825202923Details
💛 - Coveralls |
hasan-deriv
approved these changes
Sep 4, 2024
jim-deriv
approved these changes
Sep 6, 2024
niloofar-deriv
approved these changes
Sep 6, 2024
niloofar-deriv
requested changes
Sep 6, 2024
| @@ -174,11 +174,11 @@ export const patterns = { | |||
| */ | |||
| number: /\d/, | |||
| /** | |||
| * @regex /\W/ | |||
| * @description This pattern matches any string that contains special characters. | |||
| * @regex /[^\w\s£]/ | |||
There was a problem hiding this comment.
why are we customising this?
Utils is a place for having generic functions I believe it's not a good idea to exclude British from here 🤔
cc: @amam-deriv @yashim-deriv
…sign-is-not-accepted-as-a-special-character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.