Shayan/FEQ-2696/Fix redundant Cloudflare trace API calls #91
+50
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer and
niloofar-deriv
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Pull Request Test Coverage Report for Build 11885652063Details
💛 - Coveralls |
amam-deriv
requested changes
Nov 15, 2024
ameerul-deriv
approved these changes
Nov 15, 2024
Deploying deriv-utils with
|
| Latest commit: |
a8de1d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b17bc6c6.deriv-utils.pages.dev |
| Branch Preview URL: | https://shayan-feq-2696-fix-network.deriv-utils.pages.dev |
amam-deriv
reviewed
Nov 18, 2024
Co-authored-by: amam-deriv <[email protected]>
amam-deriv
reviewed
Nov 18, 2024
shayan-deriv
deleted the
shayan/FEQ-2696/fix-network-failing-on-cloudflare-cgi-trace-request
branch
|
🎉 This PR is included in version 0.0.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple simultaneous requests to
cloudflare.com/cdn-cgi/traceduring app initialization causing console errors and unnecessary network calls.Solution
Implemented Promise caching in
getCountryutility to deduplicate requests: