Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize AUTH URLs #1

Closed
Byron opened this issue Mar 2, 2015 · 0 comments · Fixed by #42
Closed

generalize AUTH URLs #1

Byron opened this issue Mar 2, 2015 · 0 comments · Fixed by #42

Comments

@Byron
Copy link
Collaborator

Byron commented Mar 2, 2015

After all, oauth is an open protocol, which is implemented by amazon as well.

This should be done soon, before the API collection comes out, as a signature change is likely to be happening.
@Byron Byron modified the milestone: 1.0.0 Apr 8, 2015
@Byron Byron removed this from the 1.0.0 milestone Aug 23, 2016
@dermesser dermesser mentioned this issue Oct 2, 2016
Merged
@Byron Byron closed this as completed in #42 Oct 9, 2016
Byron pushed a commit that referenced this issue Oct 9, 2016
@dermesser @Byron
feat(device): Make the Device flow independent of Google
a8479b8 
This is a breaking change; it's supposed to fix #1. Also, it's a
proposal -- not sure if the benefits outweigh the cost of this.

The example/auth.rs binary is not broken by this, as it doesn't use the
API that changed. The tests have been updated accordingly.
@martell martell mentioned this issue Feb 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proposal: Make the Device flow independent of Google
1 participant
@Byron