-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openssl): Update to 0.9.x #51
Conversation
This also updates hyper to 0.10.x because it uses openssl
I just reverted the fix again :( It turns out that some other dependencies still depend on openssl 0.7, and if we try and link both 0.7 and 0.9, the build fails:
funnily enough I couldn't reproduce it locally yet... |
Ahh yeah I noticed that on the build bots. |
Let me check again, because I did update the lockfile in db9824. |
aah, it's the tests. |
also, your patch fails a test. I'm fully reverting it now. I have a pull request to yup-hyper-mock which will probably solve the openssl issue. |
when that pull request has been merged, please try reapplying your patch. And please run the tests. Sorry for the mess, classic dependency hell. |
(this was the test failure: http://pastebin.com/raw/1v5MfDpq) |
@dermesser v2.0 of yup-hyper-mock was just published - let's hope that you can now proceed. |
fix(deps): Fix openssl dependency chaos and test failure (#51)
This should get rid of openssl-sys 0.7 once and for all (#51).
38fd851 fixes the last remains of this PR, especially the part where it changed RSA to HMAC, leading to 400 errors when requesting tokens. :-( |
Thanks for catching that @dermesser. |
Hey so I tried to use this on MacOS and ran into the typical rust openssl include error.
This was fixed in openssl 0.9.4.
I figured updating yup-oauth2 would help others that run into a similar issue.