Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liveliness test #443

Merged
merged 3 commits into from
May 26, 2021
Merged

Fix liveliness test #443

merged 3 commits into from
May 26, 2021

Conversation

RiccardoM
Copy link
Contributor

Description

This PR tries to fix the liveliness test

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #443 (996b7dc) into master (ba96d47) will not change coverage.
The diff coverage is n/a.

❗ Current head 996b7dc differs from pull request most recent head dcb298b. Consider uploading reports for the commit dcb298b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   72.13%   72.13%           
=======================================
  Files          73       73           
  Lines        3456     3456           
=======================================
  Hits         2493     2493           
  Misses        864      864           
  Partials       99       99           
Impacted Files Coverage Δ
app/app.go 83.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba96d47...dcb298b. Read the comment docs.

Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM force-pushed the riccardo/liveliness-test branch from 996b7dc to 56b28f9 Compare May 26, 2021 13:24
RiccardoM added 2 commits May 26, 2021 15:26
Signed-off-by: Riccardo Montagnin <[email protected]>
@RiccardoM RiccardoM requested a review from leobragaz May 26, 2021 13:31
@RiccardoM RiccardoM merged commit 6cc6a8f into master May 26, 2021
@RiccardoM RiccardoM deleted the riccardo/liveliness-test branch May 26, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants