Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(adr): ADR-009: Supply module #786

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

leobragaz
Copy link
Contributor

Description

Closes: #XXXX

ADR-009 for supply module implementation.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the kind/adr An issue or PR relating to an architectural decision record label Mar 21, 2022
@leobragaz leobragaz requested review from dadamu and RiccardoM March 21, 2022 13:13
@RiccardoM RiccardoM changed the title feat: ADR-009 Supply module docs(adr): ADR-009 Supply module Mar 21, 2022
@RiccardoM RiccardoM changed the title docs(adr): ADR-009 Supply module docs(adr): ADR-009: Supply module Mar 21, 2022
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Show resolved Hide resolved
@leobragaz leobragaz requested a review from RiccardoM March 21, 2022 15:55
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
docs/architecture/adr-009-supply-module.md Outdated Show resolved Hide resolved
@leobragaz leobragaz requested a review from RiccardoM March 21, 2022 16:09
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Mar 22, 2022
@mergify mergify bot merged commit 43d6ddf into master Mar 23, 2022
@mergify mergify bot deleted the leonardo/supply-module-adr branch March 23, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass kind/adr An issue or PR relating to an architectural decision record
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants