Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputmessage #139

Merged
merged 9 commits into from
Nov 4, 2015
Merged

Inputmessage #139

merged 9 commits into from
Nov 4, 2015

Conversation

vistajess
Copy link
Contributor

docs

Addresses #129

@@ -72,13 +72,21 @@ export default class Forms extends React.Component {

<section className="doc-bottom-space-large">
<h3 className="doc-heading">Form Error</h3>
<p>To apply, .message</p>
<p>To apply to bottom, .message</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indicate it as default rather
or like this
To apply, .message (position in bottom by default)
or
not indicate the bottom anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this message.

@JefMari
Copy link
Contributor

JefMari commented Nov 4, 2015

After this is merged, ill work on improving its documentation 👍

<section className="doc-bottom-space">
<div className="form-group">
<input className="form-control -crimson" type="text" placeholder="Enter something.." />
<div className="message">Error invalid something..</div>
</div>
</section>

<p>To apply message to top , .message .-top</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Places the message above, useful for when an overlapping element is expected (such as date picker).

@srph
Copy link
Contributor

srph commented Nov 4, 2015

LOL, you didn't commit form.scss.

@srph
Copy link
Contributor

srph commented Nov 4, 2015

Please use descriptive titles and maintain a clean commit history next time. Thanks.

srph added a commit that referenced this pull request Nov 4, 2015
@srph srph merged commit f468355 into master Nov 4, 2015
@srph srph deleted the inputmessage branch November 4, 2015 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants