upgrade slate #189
Merged
upgrade slate #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Na code review ko na. Paki double check na lang @srph |
| margin-bottom: $spacer-large; | ||
| } | ||
|
|
||
| p { | ||
| margin-bottom: $spacer-small; |
There was a problem hiding this comment.
But this means you have small space between the last paragraph and the button, right?
There was a problem hiding this comment.
yeah, though it override our default p structure given by _type.scss
There was a problem hiding this comment.
How about remove this one and include p in > *:last-child { margin-bottom: 0; }?
It will be like > p:last-child, *:last-child { margin-bottom: 0; }
|
I don't create another separate PR since this PR is all about slate For issue #173
|
|
Nice! BTW, next time please use a longer/descriptive branch (take a look on https://allenan.com/git-branch-naming-conventions/) because the branch name is fragile. |
|
Noted! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #174
For Issue #175
*Note: the second sentence is only for testing and not included as example