add new button variant #193
Conversation
|
Please Check @srph |
|
Also, does |
… into enchantment/new-button
|
Border applied! Question: How about its hover property? currently it also adopts |
|
Ask a designer. IMO, darken the text. |
… into enchantment/new-button
|
Update! |
|
Was the darkened bg intentional? |
|
nah, the text color only darken, though the bg is inherited from |
|
Can you ask Lemon? |
|
Ok! 💯 |
|
I ask sir lemon about the proper design, and this is what he wants.
hovered
|
|
What about the button in the checkut? |
|
Update! |
| @@ -53,7 +53,7 @@ | |||
| border: 1px solid $brand-gray; | |||
| } | |||
|
|
|||
| &.-primary { @include btn-variant($brand-sidebar-lt); } | |||
| &.-primary { @include btn-variant($brand-primary); } | |||
There was a problem hiding this comment.
I think there's a huge misunderstanding. Last time, we talked about changing the primary button to $brand-sidebar-lt. Why the change again? :/
|
Update! Question: should it also applied in |
|
No. Also, we might remove the inverted soon (but it has nothing to do with this). |
|
Noted! Gonna merged this na |
| &.-inverted.-default { @include btn-variant-inverted($brand-gray); } | ||
| &.-inverted.-primary { @include btn-variant-inverted($brand-sidebar-lt); } | ||
| &.-inverted.-primary { @include btn-variant-inverted($brand-primary); } |
|
What's with the new color change? |
|
I also did change of color in inverted, so i change it back :D
|
|
OK. Like I said, I have no solid opinion about this. I'd suggest you ask sir Lemon again if you're out of ideas ahah. Thanks |
For issue #162
