Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Init loaders. #53

Merged
merged 7 commits into from
Nov 4, 2015
Merged

[WIP] Init loaders. #53

merged 7 commits into from
Nov 4, 2015

Conversation

srph
Copy link
Contributor

@srph srph commented Sep 26, 2015

screen shot 2015-09-26 at 8 47 21 pm

Work in progress; do not merge.

  • Basic Loader
  • Work with buttons
  • Work with slate
  • Approval from designers

Closes #33

@srph srph mentioned this pull request Sep 26, 2015
@srph srph added the wip label Oct 27, 2015
@brianbodollo
Copy link
Contributor

loader on button
image

@brianbodollo
Copy link
Contributor

loader on slate
image

@brianbodollo
Copy link
Contributor

@srph

@srph
Copy link
Contributor Author

srph commented Oct 27, 2015

Put the loader above, just like the icons. Icons and loaders should always be placed on top in slates.

@brianbodollo
Copy link
Contributor

image

@srph
Copy link
Contributor Author

srph commented Oct 27, 2015

where's the margin? lol. thanks. anyway, i'll also wait for the buttons. lastly, ask the designers if it looks good.

We haven't received any loader design. But if they have any, discuss it to the team (us). Animated SVGs would be awesome.

* Don't forget to fix merge conflicts. This was submitted month ago (lol).

… loader-on-button

Conflicts:
	docs/dist/script.js
	docs/sections/Docs/index.jsx
@brianbodollo
Copy link
Contributor

image

…loaders

Conflicts:
	docs/dist/script.js
	docs/sections/Docs/index.jsx
@brianbodollo
Copy link
Contributor

image

@srph
Copy link
Contributor Author

srph commented Nov 4, 2015

  • Like icons, spacers should have a margin-bottom by default in Slate.
  • We need a light-colored loader.

srph added a commit that referenced this pull request Nov 4, 2015
@srph srph merged commit e0119f1 into master Nov 4, 2015
@srph srph deleted the loaders branch November 4, 2015 08:52
@srph srph removed the wip label Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants