Make symlink behavior configurable #141
Comments
|
@beyondkmp can you please take a look at this when you have a chance? |
|
This has been fixed in electron-userland/electron-builder#8560 |
|
@beyondkmp Thanks, I'll check it out once released and report back. Seems like it's a different problem and in my case it would break with a different directory structure (due to resolved symlinks), though. |
|
@mat-sz v25.1.8 has been released. You can help test it now if you have a chance. |
|
@beyondkmp Different issue now, seems also related to symlinks: |
|
@mat-sz can you share a minimum reproducible repo for this by chance? |
|
https://github.com/mat-sz/app-builder-workspace-bug-reproduction Few notes:
|
This was referenced Oct 9, 2024
Merged
beyondkmp
added a commit
to electron-userland/electron-builder
that referenced
this issue
Oct 10, 2024
fix develar/app-builder#141 reproduced error info ``` ● yarn several workspaces /tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-kIKFAh/test-project-2/packages/foo/package.json must be under /tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-kIKFAh/test-project-2/packages/test-app/ 30 | const index = file.indexOf(NODE_MODULES_PATTERN) 31 | if (index < 0) { > 32 | throw new Error(`${file} must be under ${srcWithEndSlash}`) | ^ 33 | } else { 34 | return file.substring(index + 1 /* leading slash */) 35 | } at getRelativePath (../packages/app-builder-lib/src/util/filter.ts:32:13) at AsarPackager.unpackPattern (../packages/app-builder-lib/src/util/filter.ts:57:20) at AsarPackager.createPackageFromFiles (../packages/app-builder-lib/src/asar/asarUtil.ts:129:82) at AsarPackager.pack (../packages/app-builder-lib/src/asar/asarUtil.ts:49:41) at ../packages/app-builder-lib/src/platformPackager.ts:439:11 at async Promise.all (index 0) at AsyncTaskManager.awaitTasks (../packages/builder-util/src/asyncTaskManager.ts:65:25) at LinuxPackager.doPack (../packages/app-builder-lib/src/platformPackager.ts:293:5) at LinuxPackager.pack (../packages/app-builder-lib/src/platformPackager.ts:138:5) at Packager.doBuild (../packages/app-builder-lib/src/packager.ts:459:9) at executeFinally (../packages/builder-util/src/promise.ts:12:14) at Packager.build (../packages/app-builder-lib/src/packager.ts:393:31) at packAndCheck (src/helpers/packTester.ts:188:41) at src/helpers/packTester.ts:132:36 at executeFinally (../packages/builder-util/src/promise.ts:12:14) ``` Currently, the returned node_modules paths are no longer symlinks, but resolved paths. For example, packages in pnpm workspace/yarn workspace are not under node_modules. All previous getRealSource/getRelativePath methods were based on node_modules in the path, which was relatively tricky. https://github.com/electron-userland/electron-builder/blob/a25d04d5a8e58b447f0462673a4362414da9ed27/packages/app-builder-lib/src/util/appFileCopier.ts#L191-L203 https://github.com/electron-userland/electron-builder/blob/a25d04d5a8e58b447f0462673a4362414da9ed27/packages/app-builder-lib/src/util/filter.ts#L28-L36 Solution: Directly include relativeNodeModulesPath in the file stats. This is simple and easy to understand. --------- Co-authored-by: Mike Maietta <[email protected]>
|
@mat-sz fix has landed in electron-builder v26.0.0-alpha.1. Please give it a shot when you have a chance |
mmaietta
added a commit
to electron-userland/electron-builder
that referenced
this issue
Oct 10, 2024
|
@mmaietta Thank you! Works perfectly fine on Linux. I'll try it out on Windows and macOS tomorrow and let you know if everything is also fine there. |
|
@mmaietta Apologies for the delayed response - everything works perfectly fine across all 3 platforms. Thank you once again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symlink resolution behavior introduced in 189519a breaks yarn workspaces.
Yarn tends to symlink things around when it comes to workspaces, so using any version after v5.0.0-alpha.3 results in an error similar to this (from electron-builder):
Reverting that change and rebuilding app-builder resolves those issues.
I can provide a minimal example if needed.
The text was updated successfully, but these errors were encountered: