fix: Corrects CSS output being overwritten when .cjs ext used #919
Conversation
🦋 Changeset detectedLatest commit: 97c9a46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/cjs-css
branch
from
2b451c5 to
a8b7239
Compare
|
When can this pr be merged |
rschristian
force-pushed
the
fix/cjs-css
branch
from
a8b7239 to
97c9a46
Compare
| @@ -43,3 +43,5 @@ export function safeVariableName(name) { | |||
| const identifier = normalized.replace(INVALID_ES3_IDENT, ''); | |||
| return camelCase(identifier); | |||
| } | |||
|
|
|||
| export const EXTENSION = /(\.(umd|cjs|es|m))?\.([cm]?[tj]sx?)$/; | |||
There was a problem hiding this comment.
Names are hard... 😅
Certainly open to suggestions
There was a problem hiding this comment.
Also (horrifyingly) supports the .cts and .mts extensions, as it looks like TS might head down that path
| options.output.replace( | ||
| /(\.(umd|cjs|es|m))?\.(mjs|[tj]sx?)$/, | ||
| '.css', | ||
| ), | ||
| options.output.replace(EXTENSION, '.css'), |
There was a problem hiding this comment.
This is the only regex that actually needed to be corrected. #802 missed this when adding in support, which is totally understandable given that the regex existed in 3 separate locations. Hopefully extracting this out makes it easier to handle.
Fixes #883