Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor get_assets and cache config. #131

Merged
merged 3 commits into from
Oct 22, 2020
Merged

refactor get_assets and cache config. #131

merged 3 commits into from
Oct 22, 2020

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented Oct 22, 2020 •
edited
Loading

While working in refactoring the get_assets method I found out that caching implemented in #94 wasn't working 🙈

This PR does:

  • closes Remove support for nested mosaics #122

  • move get_assets_from_json to the base class as get_assets. Then the get_assets method is used by the base methods assets_for_tile and assets_for_point (reduce code duplication)

  • refactor cache to use settings (note when TTL and/or MAXSIZE is set to 0, no cache will take place)

cc @geospatial-jeff @kylebarron

@vincentsarago vincentsarago merged commit d985054 into master Oct 22, 2020
@vincentsarago vincentsarago deleted the refactorGetAssets branch October 22, 2020 20:03
@vincentsarago vincentsarago mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for nested mosaics
1 participant
@vincentsarago