fix pagination of search results from stac-fastapi-pgstac #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… found in search response `context` object
underchemist
changed the title
matched is not found in search response context object
underchemist
changed the title
underchemist
changed the title
cogeo_mosaic/backends/stac.py
Outdated
| # Check if there is more data to fetch | ||
| if matched <= ctx["returned"]: | ||
| break | ||
| if None not in (matched, returned): |
There was a problem hiding this comment.
this is safeguarding against comparisons between int and potential None values, as that was the original issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #231
numberMatchedandnumberReturnedas part of ItemCollection response defined in STAC API spec https://github.com/radiantearth/stac-api-spec/blob/604ade6158de15b8ab068320ca41e25e2bf0e116/ogcapi-features/openapi-features.yaml#L303matchedfield not present incontextobject (pgstac?)contextin favour ofnumberMatchedhttps://stac-utils.github.io/pgstac/release-notes/#unreleased