-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom runtimes, optional VPC, python 3.11 #74
Conversation
…rfile for all apps BREAKING CHANGE: clients need to provide aws_lambda.AssetCode to configure their apps. Solely the python application and the requirements.txt file is not supported anymore.
8950777
to
eb20644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
We should make sure to document this part to explain how basic dockerfile should look
# IMPORTANT: Use the same version of python for the asset building and lambda deployment
FROM public.ecr.aws/lambda/python:3.10
WORKDIR /tmp
RUN python -m pip install pip -U
# Install application dependency
COPY runtime/requirements.txt requirements.txt
RUN python -m pip install -r requirements.txt "mangum>=0.14,<0.15" -t /asset
# Copy handler and custom code
COPY runtime/src/*.py /asset/
@emileten We should also consider adding dockerignore file with |
a79fd3c
to
a53adef
Compare
a53adef
to
385ab1b
Compare
…s. Allow the user to provide anything and let the CDK method raise error and overwrite values defined within our construct. Make this clear in the documentation
I addressed comments ; I'll see if I can fit that into eoAPI and after confirming it works I'll fix conflicts and merge. |
@vincentsarago FYI in the meanwhile (this took me forever 🙄) I did these changes (I updated the description):
This is tested in deployment and good to go, about to merge! |
95676ef
to
d59c936
Compare
BREAKING CHANGE: * database and bootstrapper constructs merged to make the bootstrapper runtime configurable * switched to `Function` for all Lambda deployments to allow for flexibility
d59c936
to
d4859f6
Compare
# [6.0.0](v5.4.1...v6.0.0) (2023-10-31) ### Features * custom runtimes, optional VPC, python 3.11 ([#74](#74)) ([ba6bf09](ba6bf09)) ### BREAKING CHANGES * the `bootstrapper` construct was deleted and is no longer available. In addition, we switched from `PythonFunction` to `Function` for all lambdas.
A large PR with several breaking changes.
database
andbootstrapper
into a single construct to avoid JSII issues. With this, all apps have their runtime configurable.Function
andfromDockerBuild
for lambda functions, because the state ofPythonFunction
makes it very hard to add flexible configurability. Now, users can override any of the lambdaFunction
parameters they want ( code, but also memory, time out...).made VPC optional for lambdas
harmonized pgstac to 0.7.10 in default runtimes.
harmonized python to 3.11 in default runtimes.