Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import without /lib or /es6 paths like fp-ts now does #55

Closed
OliverJAsh opened this issue Dec 28, 2020 · 8 comments
Closed

Import without /lib or /es6 paths like fp-ts now does #55

OliverJAsh opened this issue Dec 28, 2020 · 8 comments

Comments

@OliverJAsh
Copy link
Contributor

As per gcanti/fp-ts#1241, fp-ts now allows imports without /lib or /es6 paths, e.g.

import * as O from 'fp-ts/Option';

instead of

import * as O from 'fp-ts/lib/Option';

or

import * as O from 'fp-ts/es6/Option';

Perhaps we could make the same change to this library. WDYT?

@raveclassic
Copy link
Contributor

@OliverJAsh Unfortunately I'm not working at Devexperts anymore and I don't have write access to this repo anymore.
Ping @PalmZE

@ZUGAZ
Copy link
Contributor

ZUGAZ commented Apr 29, 2021

@OliverJAsh seem OK to me. Create PR and I will assist with merge.

@OliverJAsh
Copy link
Contributor Author

Thanks. I will just duplicate the infrastructure used by fp-ts, e.g.: gcanti/fp-ts-rxjs@d490d8c.

@mlegenhausen
Copy link
Contributor

@OliverJAsh any progress on this issue?

@OliverJAsh
Copy link
Contributor Author

Sorry I haven't had a chance to look at it, I'm not sure I will anytime soon.

@mlegenhausen
Copy link
Contributor

@OliverJAsh I picked up the issue cause this is currently bothering my tree shaking efforts 😉

@ZUGAZ
Copy link
Contributor

ZUGAZ commented Jul 22, 2021

Thank you @mlegenhausen @OliverJAsh
Merged #65. Will release soon.

@ZUGAZ ZUGAZ closed this as completed Sep 7, 2021
@ZUGAZ
Copy link
Contributor

ZUGAZ commented Sep 7, 2021

Released in version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants